[Discover] Skip loading filter if navigating to a saved search without params #10913
Conversation
…t params Signed-off-by: Joey Liu <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10913 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 4533 4533
Lines 122209 122216 +7
Branches 20483 20486 +3
=======================================
+ Hits 74250 74255 +5
- Misses 42719 42723 +4
+ Partials 5240 5238 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Maosaic
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Maosaic
requested review from
TackAdam,
angle943,
d-buckner,
huyaboo,
joshuali925,
paulstn,
ps48,
raintygao,
ruchidh,
sejli,
sumukhswamy and
wanglam
as code owners
| const currentHash = window.location.hash.split('?')[0]; | ||
| const isSavedSearchUrl = currentHash.includes('#/view/'); | ||
| const hasUrlParams = window.location.hash.includes('?'); | ||
| const shouldSkipFilters = isSavedSearchUrl && !hasUrlParams; |
There was a problem hiding this comment.
Didn't get why it should check hasUrlParams here, could you elaborate please?
| syncKeys.push('appFilters'); | ||
| } | ||
|
|
||
| const initialStateFromURL: QueryState = osdUrlStateStorage.get('_q') ?? { |
There was a problem hiding this comment.
maybe unrelated to this PR: the name initialStateFromURL is a bit misleading, because it's not just url state, it also reads in-memory state
There was a problem hiding this comment.
Maybe unrelated to this PR, it seems in connectStorageToQueryState, we're doing two-way state syncing memory state <-> url sate, do you know the intention?
2 participants
Description
When user click on saved search on Assets page, it will navigate the user to Discover page and load the saved search. However, if user had visited Discover before in same session, Discover will automatcally append the filter state from the previous visit.
This PR allow skip loading previous filter, when user visit Discover page with URL contains saved search without params.
Issues Resolved
fixes #10811
Screenshot
Before:
Screen.Recording.2025-11-12.at.12.18.05.PM.mp4
After:
Screen.Recording.2025-11-12.at.6.21.57.PM.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration